Re: [PATCH v2] media: venus: add debugfs support

From: kbuild test robot
Date: Fri Dec 28 2018 - 06:48:41 EST


Hi Malathi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20181224]
[cannot apply to v4.20]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Malathi-Gottam/media-venus-add-debugfs-support/20181228-172634
base: git://linuxtv.org/media_tree.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All warnings (new ones prefixed by >>):

In file included from include/linux/printk.h:7:0,
from include/linux/kernel.h:14,
from include/linux/clk.h:16,
from drivers/media/platform/qcom/venus/core.c:15:
drivers/media/platform/qcom/venus/core.c: In function 'venus_debugfs_init_drv':
>> include/linux/kern_levels.h:5:18: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'struct dentry *' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
#define KERN_INFO KERN_SOH "6" /* informational */
^~~~~~~~
include/linux/printk.h:315:9: note: in expansion of macro 'KERN_INFO'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~
drivers/media/platform/qcom/venus/core.h:55:4: note: in expansion of macro 'pr_info'
pr_info("venus:" fmt, \
^~~~~~~
drivers/media/platform/qcom/venus/core.c:55:3: note: in expansion of macro 'dprintk'
dprintk(ERR, "Failed creating debugfs file '%pd/%s'\n", \
^~~~~~~
drivers/media/platform/qcom/venus/core.c:63:2: note: in expansion of macro '__debugfs_create'
__debugfs_create(x32, "debug_level", &venus_debug);
^~~~~~~~~~~~~~~~
drivers/media/platform/qcom/venus/core.c:55:52: note: format string is defined here
dprintk(ERR, "Failed creating debugfs file '%pd/%s'\n", \
~^
In file included from include/linux/printk.h:7:0,
from include/linux/kernel.h:14,
from include/linux/clk.h:16,
from drivers/media/platform/qcom/venus/core.c:15:
include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
#define KERN_INFO KERN_SOH "6" /* informational */
^~~~~~~~
include/linux/printk.h:315:9: note: in expansion of macro 'KERN_INFO'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~
drivers/media/platform/qcom/venus/core.h:55:4: note: in expansion of macro 'pr_info'
pr_info("venus:" fmt, \
^~~~~~~
drivers/media/platform/qcom/venus/core.c:55:3: note: in expansion of macro 'dprintk'
dprintk(ERR, "Failed creating debugfs file '%pd/%s'\n", \
^~~~~~~
drivers/media/platform/qcom/venus/core.c:63:2: note: in expansion of macro '__debugfs_create'
__debugfs_create(x32, "debug_level", &venus_debug);
^~~~~~~~~~~~~~~~
drivers/media/platform/qcom/venus/core.c: In function 'venus_clks_enable':
include/linux/kern_levels.h:5:18: warning: format '%d' expects argument of type 'int', but argument 2 has type 'char *' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
#define KERN_INFO KERN_SOH "6" /* informational */
^~~~~~~~
include/linux/printk.h:315:9: note: in expansion of macro 'KERN_INFO'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~
drivers/media/platform/qcom/venus/core.h:55:4: note: in expansion of macro 'pr_info'
pr_info("venus:" fmt, \
^~~~~~~
drivers/media/platform/qcom/venus/core.c:185:2: note: in expansion of macro 'dprintk'
dprintk(ERR, "Failed to enable clk:%d\n", i);
^~~~~~~
drivers/media/platform/qcom/venus/core.c:185:38: note: format string is defined here
dprintk(ERR, "Failed to enable clk:%d\n", i);
~^
%s
In file included from include/linux/printk.h:7:0,
from include/linux/kernel.h:14,
from include/linux/clk.h:16,
from drivers/media/platform/qcom/venus/core.c:15:
include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
#define KERN_INFO KERN_SOH "6" /* informational */
^~~~~~~~
include/linux/printk.h:315:9: note: in expansion of macro 'KERN_INFO'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~
drivers/media/platform/qcom/venus/core.h:55:4: note: in expansion of macro 'pr_info'
pr_info("venus:" fmt, \
^~~~~~~
drivers/media/platform/qcom/venus/core.c:185:2: note: in expansion of macro 'dprintk'
dprintk(ERR, "Failed to enable clk:%d\n", i);
^~~~~~~
drivers/media/platform/qcom/venus/core.c: In function 'venus_probe':
include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
#define KERN_INFO KERN_SOH "6" /* informational */
^~~~~~~~
include/linux/printk.h:315:9: note: in expansion of macro 'KERN_INFO'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~
drivers/media/platform/qcom/venus/core.h:55:4: note: in expansion of macro 'pr_info'
pr_info("venus:" fmt, \
^~~~~~~
drivers/media/platform/qcom/venus/core.c:297:3: note: in expansion of macro 'dprintk'
dprintk(ERR, "Failed to ioremap platform resources");
^~~~~~~
include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^

vim +5 include/linux/kern_levels.h

314ba352 Joe Perches 2012-07-30 4
04d2c8c8 Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */
04d2c8c8 Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001'
04d2c8c8 Joe Perches 2012-07-30 7

:::::: The code at line 5 was first introduced by commit
:::::: 04d2c8c83d0e3ac5f78aeede51babb3236200112 printk: convert the format for KERN_<LEVEL> to a 2 byte pattern

:::::: TO: Joe Perches <joe@xxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip