Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM

From: Finn Thain
Date: Fri Dec 28 2018 - 21:33:55 EST


On Sat, 29 Dec 2018, Michael Schmitz wrote:

>
> IS_BUILTIN(CONFIG_NVRAM) is probably what Christophe really meant to suggest.
>
> Or (really going out on a limb here):
>
> IS_BUILTIN(CONFIG_NVRAM) ||
> ( IS_MODULE(CONFIG_ATARI_SCSI) && IS_ENABLED(CONFIG_NVRAM) )
>
> Not that I'd advocate that, for this series.
>

Well, you are a maintainer for atari_scsi.c.

Are you saying that you want IS_BUILTIN(CONFIG_NVRAM) used here instead of
ifdef?

OTOH, if you approve of the existing patch, please send your acked-by.

--

> Cheers,
>
> Michael
>
>
>
>