Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM
From: Michael Schmitz
Date: Fri Dec 28 2018 - 21:50:36 EST
Am 29.12.2018 um 15:34 schrieb Finn Thain:
On Sat, 29 Dec 2018, Michael Schmitz wrote:
IS_BUILTIN(CONFIG_NVRAM) is probably what Christophe really meant to suggest.
Or (really going out on a limb here):
( IS_MODULE(CONFIG_ATARI_SCSI) && IS_ENABLED(CONFIG_NVRAM) )
Not that I'd advocate that, for this series.
Well, you are a maintainer for atari_scsi.c.
Are you saying that you want IS_BUILTIN(CONFIG_NVRAM) used here instead of
No, just pointing out that there would be a way to avoid the ifdef
without messing up driver behaviour. I'm fine with the ifdef - not least
because it clearly eliminates code that would be unreachable.
(On second thought - I don't want to speculate whether there's weird
compiler options that could result in the nvram_check_checksum and
nvram_read_bytes symbols to still be referenced in the final link, even
though IS_BUILTIN(CONFIG_NVRAM) always evaluates to false. Best leave
OTOH, if you approve of the existing patch, please send your acked-by.
Of course - I'd seen Geert's acked-by on some of the patches and forgot
to check which still required acks.