Re: [PATCH] scripts: unify system call table generation scripts

From: Geert Uytterhoeven
Date: Thu Jan 03 2019 - 07:33:51 EST

Hi Firoz,

On Thu, Jan 3, 2019 at 12:55 PM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote:
> On Thu, 3 Jan 2019 at 17:04, Firoz Khan <firoz.khan@xxxxxxxxxx> wrote:
> > > +fileguard=_UAPI_ASM_`basename "$out" | sed \
> >
> > Currently, all but MIPS have the architecture name included in
> > the file guard. Shouldn't that be retained?
> I was planning to do something similar to this:
> -fileguard=_UAPI_ASM_`basename "$out" | sed \
> +fileguard=_UAPI_ASM_${ARCH}_`basename "$out" | sed \
> But later I thought, the generated file will present inside arch
> directory (eg: arch/m68k/include/generated/uapi/asm/unistd.h).
> So Is that required to mention the architecture name in the file
> guard as it is generated inside the respective arch directory?

unistd_32.h is copied to /usr/include/asm/unistd_32.h by
"make headers_install", after which the architecture name is no longer present
in the path.



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds