Re: [PATCH 0/3] firmware_loader: few selftest fixes
From: Greg KH
Date: Sat Feb 09 2019 - 03:25:07 EST
On Fri, Feb 08, 2019 at 10:57:35AM -0700, shuah wrote:
> On 2/7/19 12:05 PM, Luis R. Rodriguez wrote:
> > From: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> > Greg,
> > I've found that Dan's patches really broke firmware testing. I've
> > identified a proper fix for the issue he found, its the last patch. This
> > series reverts his two patches which break testing, and fixes the issue
> > he was running into. I leave it to him as exercise to add a busybox bash
> > quirk for the bash issue he found with diff.
> > His patches are merged on v5.0-rc1 as such these should go to Linus
> > tree as well. They are regressions on v5.0-rc1. Please let me know if
> > there are any questions.
> > Luis
> > Luis Chamberlain (3):
> > Revert "selftests: firmware: add CONFIG_FW_LOADER_USER_HELPER_FALLBACK
> > to config"
> > Revert "selftests: firmware: remove use of non-standard diff -Z
> > option"
> > selftests: firmware: fix verify_reqs() return value
> > tools/testing/selftests/firmware/config | 1 -
> > tools/testing/selftests/firmware/fw_filesystem.sh | 9 ++++++---
> > tools/testing/selftests/firmware/fw_lib.sh | 2 +-
> > 3 files changed, 7 insertions(+), 5 deletions(-)
> Luis: Thanks for finding and fixing the problems. My apologies
> for pulling the problem patch in by mistake in the first place. :(
> Greg! Do you plan to take these through firmware or do you want
> me to get these in through kselftest tree. Either way is fine.
> Acked-by: Shuah Khan <shuah@xxxxxxxxxx>
I already queued these up in my tree yesterday, so no need to add them