Re: [PATCH] huegtlbfs: fix page leak during migration of file pages

From: Mike Kravetz
Date: Mon Feb 11 2019 - 21:39:15 EST

On 2/11/19 6:24 PM, Naoya Horiguchi wrote:
> On Mon, Feb 11, 2019 at 03:06:27PM -0800, Mike Kravetz wrote:
>> While looking at this, I think there is another issue. When a hugetlb
>> page is migrated, we do not migrate the 'page_huge_active' state of the
>> page. That should be moved as the page is migrated. Correct?
> Yes, and I think that putback_active_hugepage(new_hpage) at the last step
> of migration sequence handles the copying of 'page_huge_active' state.

Thanks! I missed the putback_active_hugepage that takes care of making
the target migration page active.

Mike Kravetz