Re: [PATCH] mmc: sdhci-xenon: Mark expected switch fall-through

[Gustavo A. R. Silva]

On 2/13/19 2:35 AM, Ulf Hansson wrote:
> On Tue, 12 Feb 2019 at 16:26, Gustavo A. R. Silva
> <gustavo@xxxxxxxxxxxxxx> wrote:
>>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/mmc/host/sdhci-xenon-phy.c: In function âxenon_emmc_phy_slow_modeâ:
>> drivers/mmc/host/sdhci-xenon-phy.c:527:47: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    if ((priv->init_card_type == MMC_TYPE_SDIO) ||
>>        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
>>        params->slow_mode) {
>>        ~~~~~~~~~~~~~~~~~
>> drivers/mmc/host/sdhci-xenon-phy.c:534:2: note: here
>>   default:
>>   ^~~~~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> 
> Applied for next - and by cleaning up the somewhat noisy change log, thanks!
> 

Great.

Thanks, Uffe.

--
Gustavo