Re: [PATCHv5] random: Make /dev/random wait for input_pool initializedy
From: Theodore Y. Ts'o
Date: Wed Feb 20 2019 - 19:32:32 EST
Hi Brend,
I've been looking at your patch, and as far as the core part of what
you're patching, I think this patch below is a conceptually simpler
way of fixing the original core problem. Please take a look and let
me know what you think.
There are some other auxiliary things that your patch is trying to do
where I'm not sure what you're trying to doing and I'm not at all sure
it's correct. Those things should really get separated out as a
separate patches.
> Another minor tweak this patch makes, is when the primary
> CRNG is periodically reseeded, we reserve twice the amount
> of read_wakeup_threshold for fairness reasons, to keep
> /dev/random readable when it is not accessed by user mode.
I'm not sure what you're trying to do/fix here.
- Ted