Re: [PATCH v2] mfd: cros_ec: instantiate properly CrOS ISH MCU device

[Rushikesh S Kadam]

Hi Andy

On Fri, Mar 01, 2019 at 09:28:11AM +0200, Andy Shevchenko wrote:
> On Fri, Mar 01, 2019 at 09:36:11AM +0530, Rushikesh S Kadam wrote:
> > Integrated Sensor Hub (ISH) is also a MCU running EC
> > having feature bit EC_FEATURE_ISH. Instantiate it as
> > a special CrOS EC device with device name 'cros_ish'.
> 
> > v2
> > - Addressed review comments to term the CrOS EC device as a generic
> >   Integrated Sensor Hub. 
> 
> > +	/* The MCU is an Intel Integrated Sensor Hub */
> 
> This has to be adjusted as well. Intel ISH is just one of the example of ISHs.

Thanks for the catch

I submitted v3 with this fixed

Regards
Rushikesh

> 
> > +	EC_FEATURE_ISH = 40,
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

--