Re: [PATCH] printk: Remove no longer used LOG_PREFIX.

[Petr Mladek]

On Fri 2019-03-01 19:31:59, Tetsuo Handa wrote:
> Can this patch go to Linux 5.1?

I am going to look at it the following week. I do not think that
it is necessary to hurry a clean up of old stuff up into 5.1.

I believe that it is correct. But it is not a typo fix. For example,
I want to double check what was the history of KERN_DEFAULT defined
as "d". It existed since ages...

Best Regards,
Petr

> On 2019/02/22 18:59, Tetsuo Handa wrote:
> > When commit 5becfb1df5ac8e49 ("kmsg: merge continuation records while
> > printing") introduced LOG_PREFIX, we used KERN_DEFAULT etc. as a flag
> > for setting LOG_PREFIX in order to tell whether to call cont_add()
> > (i.e. whether to append the message to "struct cont").
> > 
> > But since commit 4bcc595ccd80decb ("printk: reinstate KERN_CONT for
> > printing continuation lines") inverted the behavior (i.e. don't append
> > the message to "struct cont" unless KERN_CONT is specified) and commit
> > 5aa068ea4082b39e ("printk: remove games with previous record flags")
> > removed the last LOG_PREFIX check, setting LOG_PREFIX via KERN_DEFAULT
> > etc. is no longer meaningful.
> > 
> > Therefore, we can remove LOG_PREFIX and make KERN_DEFAULT empty string.
> > 
> > Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> > ---
> >  include/linux/kern_levels.h | 2 +-
> >  include/linux/printk.h      | 1 -
> >  kernel/printk/printk.c      | 6 +-----
> >  3 files changed, 2 insertions(+), 7 deletions(-)