Re: [PATCH] fbdev: omap2: fix warnings in dss core

From: Bartlomiej Zolnierkiewicz
Date: Fri Mar 01 2019 - 09:45:59 EST



On 02/13/2019 09:47 AM, Anders Roxell wrote:
> Commit 60d2fa0dad06 ("fbdev: omap2: no need to check return value of
> debugfs_create functions") changed the declaration of the return value
> of function dss_debugfs_create_file() and the following two warnings
> appeared:
>
> drivers/video/fbdev/omap2/omapfb/dss/core.c: In function âdss_debugfs_create_fileâ:
> drivers/video/fbdev/omap2/omapfb/dss/core.c:139:9: warning: âreturnâ with a value,
> in function returning void
> return 0;
> ^
> drivers/video/fbdev/omap2/omapfb/dss/core.c: In function âomap_dss_probeâ:
> drivers/video/fbdev/omap2/omapfb/dss/core.c:172:6: warning: unused variable ârâ
> [-Wunused-variable]
> int r;
> ^
>
> Rework so function dss_debugfs_create_file() that is declared to return
> void don't 'return 0' and remove the declaration of the unused variable
> 'r'.
>
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>

Patch queued for v5.1, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics