Re: [PATCH v2] scsi: smartpqi_init: Reporting 'logical unit failure'

From: Erwan Velu
Date: Fri Mar 01 2019 - 10:43:40 EST

Le 01/03/2019 Ã 16:26, James Bottomley a ÃcritÂ:
> [...]
> Shouldn't this be a variant of sdev/scmd_printk? Otherwise it tells
> you what disk in the array terms is the problem but not what device in
> your actual system is affected.

Hey James,

My initial take on that was that pqi_take_device_offline(), which is
called just after, will print the "re-scanning " message with the same

As they will be both printed in the same error context and one after the
other, I though that would make sense to represent the same information
to ease the reading like cause -> consequence.

As the message is about the LUN itself, which is reported faulty, I
though it would worth reporting the info that way.

Shall I consider printing also the disk name in addition ?