Re: [PATCH 6/8] i915,uaccess: Fix redundant CLAC

From: Linus Torvalds
Date: Fri Mar 01 2019 - 11:15:31 EST


On Fri, Mar 1, 2019 at 4:57 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> Or.. we move the thing to assembly. Of course, I suck at (writing) asm,
> so the below is probably broken in various ways.

Looks sane, and makes sense. I feel that the old "mixed C and asm" was
much worse.

My only comment is that I think you should remove the ENTRY() one,
because you don't actually want that symbol to be global any more,
because I think it's all from inside copy_user_64.S now.

So just

ALIGN
copy_user_handle_tail:
.. code goes here..

Hmm?

Linus