Re: [PATCH] usb: core: make default autosuspend delay configurable

From: Greg Kroah-Hartman
Date: Fri Mar 01 2019 - 11:23:47 EST


On Fri, Mar 01, 2019 at 02:26:46PM +0000, Mans Rullgard wrote:
> Make the default autosuspend delay configurable at build time.
> This is useful for systems that require a non-standard value as
> it avoids relying on the command line being properly set.
>
> Signed-off-by: Mans Rullgard <mans@xxxxxxxxx>
> ---
> drivers/usb/core/Kconfig | 8 ++++++++
> drivers/usb/core/usb.c | 4 ++--
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index 4d75d9a80001..38ed837538c4 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -90,3 +90,11 @@ config USB_LEDS_TRIGGER_USBPORT
> This driver allows LEDs to be controlled by USB events. Enabling this
> trigger allows specifying list of USB ports that should turn on LED
> when some USB device gets connected.
> +
> +config USB_AUTOSUSPEND_DELAY
> + int "Default autosuspend delay"
> + depends on USB
> + default 2
> + help
> + The default autosuspend delay in seconds. Can be overridden
> + with the usbcore.autosuspend command line or module parameter.

As everyone is suddenly going to be hit with this for a new kernel
upate, you might want to put something in here that says:
The default value Linux has always had is 2 seconds. Change
this value if you want a different delay timeframe and can not
modify the command line or module parameter option.

to make people a lot more comfortable with this change.

thanks,

greg k-h