Re: [PATCH 2/2] spi: dw: Add support for an optional interface clock

[Mark Brown]

On Thu, Feb 28, 2019 at 01:25:42PM +0000, Gareth Williams wrote:
> From: Phil Edworthy <phil.edworthy@xxxxxxxxxxx>
> 
> The Synopsys SSI Controller has an interface clock, but most SoCs hide 
> this away. However, on some SoCs you need to explicity enable the 
> interface clock in order to access the registers. Therefore, add 
> support for an optional interface clock.

This doesn't build for me:

  CC      drivers/spi/spi-dw-mmio.o
drivers/spi/spi-dw-mmio.c: In function âdw_spi_mmio_probeâ:
drivers/spi/spi-dw-mmio.c:177:18: error: implicit declaration of function âdevm_clk_get_optionalâ; did you mean âdevm_gpiod_get_optionalâ? [-Werror=implicit-function-declaration]
  dwsmmio->pclk = devm_clk_get_optional(&pdev->dev, "pclk");
                  ^~~~~~~~~~~~~~~~~~~~~
                  devm_gpiod_get_optional
drivers/spi/spi-dw-mmio.c:177:16: warning: assignment to âstruct clk *â from âintâ makes pointer from integer without a cast [-Wint-conversion]
  dwsmmio->pclk = devm_clk_get_optional(&pdev->dev, "pclk");
                ^

Attachment: signature.asc
Description: PGP signature