//Re: [PATCH v3 06/12] usb: dwc3: Increase timeout for CmdAct cleared by device controller

[Chen Yu]

Hi Zhang Fei,

On 2019/3/2 23:47, Andy Shevchenko wrote:
> On Sat, Mar 2, 2019 at 11:06 AM Yu Chen <chenyu56@xxxxxxxxxx> wrote:
>>
>> It needs more time for the device controller to clear the CmdAct of
>> DEPCMD on Hisilicon Kirin Soc.
>>
> 
> 5x times more? Can you provide more specific details on that?
> 
Can you explain the details about the timeout expansion on Hisilicon Kirin Soc?
Thanks!

>> Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>> Cc: Felipe Balbi <balbi@xxxxxxxxxx>
>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> Cc: John Stultz <john.stultz@xxxxxxxxxx>
>> Cc: Binghui Wang <wangbinghui@xxxxxxxxxxxxx>
>> Signed-off-by: Yu Chen <chenyu56@xxxxxxxxxx>
>> ---
>>  drivers/usb/dwc3/gadget.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
>> index 6c9b76bcc2e1..84d701b37171 100644
>> --- a/drivers/usb/dwc3/gadget.c
>> +++ b/drivers/usb/dwc3/gadget.c
>> @@ -270,7 +270,7 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned cmd,
>>  {
>>         const struct usb_endpoint_descriptor *desc = dep->endpoint.desc;
>>         struct dwc3             *dwc = dep->dwc;
>> -       u32                     timeout = 1000;
>> +       u32                     timeout = 5000;
>>         u32                     saved_config = 0;
>>         u32                     reg;
>>
>> --
>> 2.15.0-rc2
>>
> 
>