Re: [PATCH] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm

From: kbuild test robot
Date: Mon Mar 04 2019 - 02:49:52 EST

Next
Previous
In reply
Next
Messages

Hi Su,

Thank you for the
[auto build test [also build test [if your patch is
url: # apt-get install sparse
make ARCH=x86_64 make C=1
All warnings (new
>> net/xfrm/xfrm net/xfrm/xfrm_user.c:1198:39: net/xfrm/xfrm_user.c:1198:39: net/xfrm/xfrm_user.c:1257:39: net/xfrm/xfrm_user.c:1257:39: net/xfrm/xfrm_user.c:1257:39: net/xfrm/xfrm_user.c:1277:46: net/xfrm/xfrm_user.c:1277:46: net/xfrm/xfrm_user.c:1277:46: net/xfrm/xfrm_user.c:1340:38: net/xfrm/xfrm_user.c:1340:38: net/xfrm/xfrm_user.c:1340:38: net/xfrm/xfrm_user.c:1906:54: net/xfrm/xfrm_user.c:1906:54: net/xfrm/xfrm_user.c:1906:54: net/xfrm/xfrm_user.c:2065:38: net/xfrm/xfrm_user.c:2065:38: net/xfrm/xfrm_user.c:2065:38: net/xfrm/xfrm_user.c:2655:60: net/xfrm/xfrm_user.c:2655:60: net/xfrm/xfrm_user.c:2655:60:
sparse warnings:
net/xfrm/xfrm_user.c:1198:39: >> net/xfrm/xfrm >> net/xfrm/xfrm net/xfrm/xfrm_user.c:1257:39: net/xfrm/xfrm_user.c:1257:39: net/xfrm/xfrm_user.c:1257:39: net/xfrm/xfrm_user.c:1277:46: net/xfrm/xfrm_user.c:1277:46: net/xfrm/xfrm_user.c:1277:46: net/xfrm/xfrm_user.c:1340:38: net/xfrm/xfrm_user.c:1340:38: net/xfrm/xfrm_user.c:1340:38: net/xfrm/xfrm_user.c:1906:54: net/xfrm/xfrm_user.c:1906:54: net/xfrm/xfrm_user.c:1906:54: net/xfrm/xfrm_user.c:2065:38: net/xfrm/xfrm_user.c:2065:38: net/xfrm/xfrm_user.c:2065:38: net/xfrm/xfrm_user.c:2655:60: >> net/xfrm/xfrm net/xfrm/xfrm_user.c:2655:60:
vim +1198 net/xfrm/xfrm_user.c

880a6fab Christophe Gouault ecfd6b18 Jamal Hadi Salim 5424f32e Thomas Graf ecfd6b18 Jamal Hadi Salim a6483b79 Alexey Dobriyan ecfd6b18 Jamal Hadi Salim 7b67c857 Thomas Graf 15e47304 Eric W. Biederman ecfd6b18 Jamal Hadi Salim 2fc5f83b Gustavo A. R. Silva ecfd6b18 Jamal Hadi Salim 7deb2264 Thomas Graf ecfd6b18 Jamal Hadi Salim ecfd6b18 Jamal Hadi Salim ecfd6b18 Jamal Hadi Salim 2fc5f83b Gustavo A. R. Silva 2fc5f83b Gustavo A. R. Silva ecfd6b18 Jamal Hadi Salim 15e47304 Eric W. Biederman ecfd6b18 Jamal Hadi Salim ecfd6b18 Jamal Hadi Salim a1b831f2 Alexey Dobriyan 7deb2264 Thomas Graf 7deb2264 Thomas Graf 7deb2264 Thomas Graf 7deb2264 Thomas Graf 7deb2264 Thomas Graf 7deb2264 Thomas Graf e071041b Alexey Dobriyan 15e47304 Eric W. Biederman 28d8909b Jamal Hadi Salim af11e316 Jamal Hadi Salim af11e316 Jamal Hadi Salim 28d8909b Jamal Hadi Salim 1d1e34dd David S. Miller 28d8909b Jamal Hadi Salim 28d8909b Jamal Hadi Salim 15e47304 Eric W. Biederman 25985edc Lucas De Marchi 28d8909b Jamal Hadi Salim 28d8909b Jamal Hadi Salim 28d8909b Jamal Hadi Salim 28d8909b Jamal Hadi Salim e071041b Alexey Dobriyan 28d8909b Jamal Hadi Salim af11e316 Jamal Hadi Salim af11e316 Jamal Hadi Salim af11e316 Jamal Hadi Salim 1d1e34dd David S. Miller 1d1e34dd David S. Miller 1d1e34dd David S. Miller 1d1e34dd David S. Miller 1d1e34dd David S. Miller 1d1e34dd David S. Miller 1d1e34dd David S. Miller 28d8909b Jamal Hadi Salim 053c095a Johannes Berg 053c095a Johannes Berg 28d8909b Jamal Hadi Salim 28d8909b Jamal Hadi Salim 28d8909b Jamal Hadi Salim 5424f32e Thomas Graf 28d8909b Jamal Hadi Salim a6483b79 Alexey Dobriyan 28d8909b Jamal Hadi Salim 7b67c857 Thomas Graf 15e47304 Eric W. Biederman 28d8909b Jamal Hadi Salim 2fc5f83b Gustavo A. R. Silva 28d8909b Jamal Hadi Salim 7deb2264 Thomas Graf 28d8909b Jamal Hadi Salim 28d8909b Jamal Hadi Salim 28d8909b Jamal Hadi Salim 2fc5f83b Gustavo A. R. Silva 2fc5f83b Gustavo A. R. Silva 28d8909b Jamal Hadi Salim 15e47304 Eric W. Biederman 28d8909b Jamal Hadi Salim 28d8909b Jamal Hadi Salim 22e70050 Christoph Hellwig 5424f32e Thomas Graf ^1da177e Linus Torvalds fc34acd3 Alexey Dobriyan 7b67c857 Thomas Graf ^1da177e Linus Torvalds ^1da177e Linus Torvalds eb2971b6 Masahide NAKAMURA ^1da177e Linus Torvalds fc34acd3 Alexey Dobriyan ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds 15e47304 Eric W. Biederman ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds 22e70050 Christoph Hellwig 5424f32e Thomas Graf ^1da177e Linus Torvalds fc34acd3 Alexey Dobriyan ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds 6f26b61e Jamal Hadi Salim 6f26b61e Jamal Hadi Salim 7e652640 Steffen Klassert ^1da177e Linus Torvalds 7b67c857 Thomas Graf 776e9dd9 Fan Du ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds 6f26b61e Jamal Hadi Salim 6f26b61e Jamal Hadi Salim 7e652640 Steffen Klassert 7e652640 Steffen Klassert 7e652640 Steffen Klassert 7e652640 Steffen Klassert ^1da177e Linus Torvalds 6f26b61e Jamal Hadi Salim 70e94e66 YOSHIFUJI ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds 6f26b61e Jamal Hadi Salim 7e652640 Steffen Klassert ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds 658b219e Herbert Xu 658b219e Herbert Xu 658b219e Herbert Xu ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds 15e47304 Eric W. Biederman ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds ^1da177e Linus Torvalds
:::::: The code :::::: 15e473046cb6e5d18a
:::::: TO: Eric :::::: CC: David
---
0-DAY kernel test infrastructure Attachment: Description: application/gzip message: Dmitry Vyukov: "Re: [PATCH] aio: prevent the final fput() in the middle of vfs_poll() (Re: KASAN: use-after-free Read in unix_dgram_poll)" message: Dmitry Vyukov: "Re: BUG: unable to handle kernel paging request in bpf_prog_kallsyms_add" to: Su Yanjun: "[PATCH] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm" in thread: Sergei Shtylyov: "Re: [PATCH] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm" sorted by: [ date ] [ thread ] [ subject ] [ author ] patch! Perhaps something to improve:
WARNING on net-next/master]
WARNING on v5.0 next-20190301]
applied to the wrong git tree, please drop us a note to help improve the system]
href="https://github.com/0day-ci/linux/commits/Su-Yanjun/net-xfrm-Add-_rcu-tag-for-rcu-protected-pointer-in-netns_xfrm/20190304-135248">https://github.com/0day-ci/linux/commits/Su-Yanjun/net-xfrm-Add-_rcu-tag-for-rcu-protected-pointer-in-netns_xfrm/20190304-135248
allmodconfig
CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
ones prefixed by >>):
_user.c:1198:39: sparse: warning: incorrect type in argument 1 (different address spaces)
sparse: expected struct sock *sk
sparse: got struct sock [noderef] <asn:4> *nlsk
sparse: warning: incorrect type in argument 1 (different address spaces)
sparse: expected struct sock *sk
sparse: got struct sock [noderef] <asn:4> *nlsk
sparse: warning: incorrect type in argument 1 (different address spaces)
sparse: expected struct sock *sk
sparse: got struct sock [noderef] <asn:4> *nlsk
sparse: warning: incorrect type in argument 1 (different address spaces)
sparse: expected struct sock *sk
sparse: got struct sock [noderef] <asn:4> *nlsk
sparse: warning: incorrect type in argument 1 (different address spaces)
sparse: expected struct sock *sk
sparse: got struct sock [noderef] <asn:4> *nlsk
sparse: warning: incorrect type in argument 1 (different address spaces)
sparse: expected struct sock *sk
sparse: got struct sock [noderef] <asn:4> *nlsk
sparse: warning: incorrect type in argument 1 (different address spaces)
sparse: expected struct sock *ssk
sparse: got struct sock [noderef] <asn:4> *nlsk
(new ones prefixed by >>)
sparse: warning: incorrect type in argument 1 (different address spaces)
_user.c:1198:39: sparse: expected struct sock *sk
_user.c:1198:39: sparse: got struct sock [noderef] <asn:4> *nlsk
sparse: warning: incorrect type in argument 1 (different address spaces)
sparse: expected struct sock *sk
sparse: got struct sock [noderef] <asn:4> *nlsk
sparse: warning: incorrect type in argument 1 (different address spaces)
sparse: expected struct sock *sk
sparse: got struct sock [noderef] <asn:4> *nlsk
sparse: warning: incorrect type in argument 1 (different address spaces)
sparse: expected struct sock *sk
sparse: got struct sock [noderef] <asn:4> *nlsk
sparse: warning: incorrect type in argument 1 (different address spaces)
sparse: expected struct sock *sk
sparse: got struct sock [noderef] <asn:4> *nlsk
sparse: warning: incorrect type in argument 1 (different address spaces)
sparse: expected struct sock *sk
sparse: got struct sock [noderef] <asn:4> *nlsk
sparse: warning: incorrect type in argument 1 (different address spaces)
_user.c:2655:60: sparse: expected struct sock *ssk
sparse: got struct sock [noderef] <asn:4> *nlsk
2014-08-29 1180
2007-04-28 1181 static int xfrm_get_spdinfo(struct sk_buff *skb, struct nlmsghdr *nlh,
2007-08-22 1182 struct nlattr **attrs)
2007-04-28 1183 {
2008-11-25 1184 struct net *net = sock_net(skb->sk);
2007-04-28 1185 struct sk_buff *r_skb;
2007-08-22 1186 u32 *flags = nlmsg_data(nlh);
2012-09-07 1187 u32 sportid = NETLINK_CB(skb).portid;
2007-04-28 1188 u32 seq = nlh->nlmsg_seq;
2017-10-26 1189 int err;
2007-04-28 1190
2007-08-22 1191 r_skb = nlmsg_new(xfrm_spdinfo_msgsize(), GFP_ATOMIC);
2007-04-28 1192 if (r_skb == NULL)
2007-04-28 1193 return -ENOMEM;
2007-04-28 1194
2017-10-26 1195 err = build_spdinfo(r_skb, net, sportid, seq, *flags);
2017-10-26 1196 BUG_ON(err < 0);
2007-04-28 1197
2012-09-07 @1198 return nlmsg_unicast(net->xfrm.nlsk, r_skb, sportid);
2007-04-28 1199 }
2007-04-28 1200
2017-09-21 1201 static inline unsigned int xfrm_sadinfo_msgsize(void)
2007-08-22 1202 {
2007-08-22 1203 return NLMSG_ALIGN(4)
2007-08-22 1204 + nla_total_size(sizeof(struct xfrmu_sadhinfo))
2007-08-22 1205 + nla_total_size(4); /* XFRMA_SAD_CNT */
2007-08-22 1206 }
2007-08-22 1207
2010-01-23 1208 static int build_sadinfo(struct sk_buff *skb, struct net *net,
2012-09-07 1209 u32 portid, u32 seq, u32 flags)
2007-04-26 1210 {
2007-05-04 1211 struct xfrmk_sadinfo si;
2007-05-04 1212 struct xfrmu_sadhinfo sh;
2007-04-26 1213 struct nlmsghdr *nlh;
2012-06-27 1214 int err;
2007-04-26 1215 u32 *f;
2007-04-26 1216
2012-09-07 1217 nlh = nlmsg_put(skb, portid, seq, XFRM_MSG_NEWSADINFO, sizeof(u32), 0);
2011-03-30 1218 if (nlh == NULL) /* shouldn't really happen ... */
2007-04-26 1219 return -EMSGSIZE;
2007-04-26 1220
2007-04-26 1221 f = nlmsg_data(nlh);
2007-04-26 1222 *f = flags;
2010-01-23 1223 xfrm_sad_getinfo(net, &si);
2007-04-26 1224
2007-05-04 1225 sh.sadhmcnt = si.sadhmcnt;
2007-05-04 1226 sh.sadhcnt = si.sadhcnt;
2007-05-04 1227
2012-06-27 1228 err = nla_put_u32(skb, XFRMA_SAD_CNT, si.sadcnt);
2012-06-27 1229 if (!err)
2012-06-27 1230 err = nla_put(skb, XFRMA_SAD_HINFO, sizeof(sh), &sh);
2012-06-27 1231 if (err) {
2012-06-27 1232 nlmsg_cancel(skb, nlh);
2012-06-27 1233 return err;
2012-06-27 1234 }
2007-04-26 1235
2015-01-16 1236 nlmsg_end(skb, nlh);
2015-01-16 1237 return 0;
2007-04-26 1238 }
2007-04-26 1239
2007-04-26 1240 static int xfrm_get_sadinfo(struct sk_buff *skb, struct nlmsghdr *nlh,
2007-08-22 1241 struct nlattr **attrs)
2007-04-26 1242 {
2008-11-25 1243 struct net *net = sock_net(skb->sk);
2007-04-26 1244 struct sk_buff *r_skb;
2007-08-22 1245 u32 *flags = nlmsg_data(nlh);
2012-09-07 1246 u32 sportid = NETLINK_CB(skb).portid;
2007-04-26 1247 u32 seq = nlh->nlmsg_seq;
2017-10-26 1248 int err;
2007-04-26 1249
2007-08-22 1250 r_skb = nlmsg_new(xfrm_sadinfo_msgsize(), GFP_ATOMIC);
2007-04-26 1251 if (r_skb == NULL)
2007-04-26 1252 return -ENOMEM;
2007-04-26 1253
2017-10-26 1254 err = build_sadinfo(r_skb, net, sportid, seq, *flags);
2017-10-26 1255 BUG_ON(err < 0);
2007-04-26 1256
2012-09-07 1257 return nlmsg_unicast(net->xfrm.nlsk, r_skb, sportid);
2007-04-26 1258 }
2007-04-26 1259
2007-01-02 1260 static int xfrm_get_sa(struct sk_buff *skb, struct nlmsghdr *nlh,
2007-08-22 1261 struct nlattr **attrs)
2005-04-16 1262 {
2008-11-25 1263 struct net *net = sock_net(skb->sk);
2007-08-22 1264 struct xfrm_usersa_id *p = nlmsg_data(nlh);
2005-04-16 1265 struct xfrm_state *x;
2005-04-16 1266 struct sk_buff *resp_skb;
2006-08-23 1267 int err = -ESRCH;
2005-04-16 1268
2008-11-25 1269 x = xfrm_user_state_lookup(net, p, attrs, &err);
2005-04-16 1270 if (x == NULL)
2005-04-16 1271 goto out_noput;
2005-04-16 1272
2005-04-16 1273 resp_skb = xfrm_state_netlink(skb, x, nlh->nlmsg_seq);
2005-04-16 1274 if (IS_ERR(resp_skb)) {
2005-04-16 1275 err = PTR_ERR(resp_skb);
2005-04-16 1276 } else {
2012-09-07 1277 err = nlmsg_unicast(net->xfrm.nlsk, resp_skb, NETLINK_CB(skb).portid);
2005-04-16 1278 }
2005-04-16 1279 xfrm_state_put(x);
2005-04-16 1280 out_noput:
2005-04-16 1281 return err;
2005-04-16 1282 }
2005-04-16 1283
2007-01-02 1284 static int xfrm_alloc_userspi(struct sk_buff *skb, struct nlmsghdr *nlh,
2007-08-22 1285 struct nlattr **attrs)
2005-04-16 1286 {
2008-11-25 1287 struct net *net = sock_net(skb->sk);
2005-04-16 1288 struct xfrm_state *x;
2005-04-16 1289 struct xfrm_userspi_info *p;
2005-04-16 1290 struct sk_buff *resp_skb;
2005-04-16 1291 xfrm_address_t *daddr;
2005-04-16 1292 int family;
2005-04-16 1293 int err;
2010-02-22 1294 u32 mark;
2010-02-22 1295 struct xfrm_mark m;
2018-06-12 1296 u32 if_id = 0;
2005-04-16 1297
2007-08-22 1298 p = nlmsg_data(nlh);
2013-12-16 1299 err = verify_spi_info(p->info.id.proto, p->min, p->max);
2005-04-16 1300 if (err)
2005-04-16 1301 goto out_noput;
2005-04-16 1302
2005-04-16 1303 family = p->info.family;
2005-04-16 1304 daddr = &p->info.id.daddr;
2005-04-16 1305
2005-04-16 1306 x = NULL;
2010-02-22 1307
2010-02-22 1308 mark = xfrm_mark_get(attrs, &m);
2018-06-12 1309
2018-06-12 1310 if (attrs[XFRMA_IF_ID])
2018-06-12 1311 if_id = nla_get_u32(attrs[XFRMA_IF_ID]);
2018-06-12 1312
2005-04-16 1313 if (p->info.seq) {
2010-02-22 1314 x = xfrm_find_acq_byseq(net, mark, p->info.seq);
Hideaki / åèèæ 2013-01-29 1315 if (x && !xfrm_addr_equal(&x->id.daddr, daddr, family)) {
2005-04-16 1316 xfrm_state_put(x);
2005-04-16 1317 x = NULL;
2005-04-16 1318 }
2005-04-16 1319 }
2005-04-16 1320
2005-04-16 1321 if (!x)
2010-02-22 1322 x = xfrm_find_acq(net, &m, p->info.mode, p->info.reqid,
2018-06-12 1323 if_id, p->info.id.proto, daddr,
2005-04-16 1324 &p->info.saddr, 1,
2005-04-16 1325 family);
2005-04-16 1326 err = -ENOENT;
2005-04-16 1327 if (x == NULL)
2005-04-16 1328 goto out_noput;
2005-04-16 1329
2007-10-09 1330 err = xfrm_alloc_spi(x, p->min, p->max);
2007-10-09 1331 if (err)
2007-10-09 1332 goto out;
2005-04-16 1333
2005-04-16 1334 resp_skb = xfrm_state_netlink(skb, x, nlh->nlmsg_seq);
2005-04-16 1335 if (IS_ERR(resp_skb)) {
2005-04-16 1336 err = PTR_ERR(resp_skb);
2005-04-16 1337 goto out;
2005-04-16 1338 }
2005-04-16 1339
2012-09-07 @1340 err = nlmsg_unicast(net->xfrm.nlsk, resp_skb, NETLINK_CB(skb).portid);
2005-04-16 1341
2005-04-16 1342 out:
2005-04-16 1343 xfrm_state_put(x);
2005-04-16 1344 out_noput:
2005-04-16 1345 return err;
2005-04-16 1346 }
2005-04-16 1347
at line 1198 was first introduced by commit
4d0057e61d76315230382b netlink: Rename pid to portid to avoid confusion
W. Biederman <ebiederm@xxxxxxxxxxxx>
S. Miller <davem@xxxxxxxxxxxxx>
Open Source Technology Center
href="https://lists.01.org/pipermail/kbuild-all">https://lists.01.org/pipermail/kbuild-all Intel Corporation
>.config.gz

Next message: Dmitry Vyukov: "Re: [PATCH] aio: prevent the final fput() in the middle of vfs_poll() (Re: KASAN: use-after-free Read in unix_dgram_poll)"
Previous message: Dmitry Vyukov: "Re: BUG: unable to handle kernel paging request in bpf_prog_kallsyms_add"
In reply to: Su Yanjun: "[PATCH] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm"
Next in thread: Sergei Shtylyov: "Re: [PATCH] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]