Re: [PATCH v10 12/27] pwm: jz4740: Use regmap from TCU driver

[Thierry Reding]

On Sat, Mar 02, 2019 at 08:33:58PM -0300, Paul Cercueil wrote:
> The ingenic-timer "TCU" driver provides us with a regmap, that we can
> use to safely access the TCU registers.
> 
> While this driver is devicetree-compatible, it is never (as of now)
> probed from devicetree, so this change does not introduce a ABI problem
> with current devicetree files.
> 
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> Tested-by: Mathieu Malaterre <malat@xxxxxxxxxx>
> Tested-by: Artur Rojek <contact@xxxxxxxxxxxxxx>
> ---
> 
> Notes:
>          v9: New patch
>     
>          v10: No change
> 
>  drivers/pwm/Kconfig      |  1 +
>  drivers/pwm/pwm-jz4740.c | 74 +++++++++++++++++++++++++++++++-----------------
>  2 files changed, 49 insertions(+), 26 deletions(-)
> 
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index a8f47df0655a..ace8ea4b6247 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -204,6 +204,7 @@ config PWM_IMX
>  config PWM_JZ4740
>  	tristate "Ingenic JZ47xx PWM support"
>  	depends on MACH_INGENIC
> +	select REGMAP

Sounds to me like "depends INGENIC_TCU" would be more appropriate here.

Thierry

Attachment: signature.asc
Description: PGP signature