Re: çå: [PATCH V4] sched/cpufreq: initialize iowait_boost_max and iowait_boost with cpu capacity

From: Peter Zijlstra
Date: Mon Mar 04 2019 - 12:45:00 EST


On Mon, Mar 04, 2019 at 06:40:28PM +0100, Peter Zijlstra wrote:

> /*
> * @util is already in capacity scale, convert iowait_boost
> * into the same scale so we can compare.
> */
> boost = (sg_cpu->iowait_boost * max) >> SCHED_CAPACITY_SHIFT;
> util = max(boost, util);
> return min(util, max);

Ah, I don't think we need that last min in this case; both terms should
already be <= SCHED_CAPACITY_SCALE.