Re: [PATCH resend] thermal: bcm2835: Fix crash in bcm2835_thermal_debugfs

[Eric Anholt]

Phil Elwell <phil@xxxxxxxxxxxxxxx> writes:

> "cat /sys/kernel/debug/bcm2835_thermal/regset" causes a NULL pointer
> dereference in bcm2835_thermal_debugfs. The driver makes use of the
> implementation details of the thermal framework to retrieve a pointer
> to its private data from a struct thermal_zone_device, and gets it
> wrong - leading to the crash. Instead, store its private data as the
> drvdata and retrieve the thermal_zone_device pointer from it.
>
> Fixes: bcb7dd9ef206 ("thermal: bcm2835: add thermal driver for bcm2835 SoC")
>
> Signed-off-by: Phil Elwell <phil@xxxxxxxxxxxxxxx>

Acked-by: Eric Anholt <eric@xxxxxxxxxx>

From the thread that missed Ccing the maintainers there was also:

Reviewed-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature