Re: [PATCH net] net: hns3: add rmb() for rx description

[tanhuazhong]

On 2019/3/4 13:15, David Miller wrote:
> From: Huazhong Tan <tanhuazhong@xxxxxxxxxx>
> Date: Sat, 2 Mar 2019 16:49:30 +0800
>
> > From: Jian Shen <shenjian15@xxxxxxxxxx>
> >
> > HW can not guarantee complete write desc->rx.size, even though
> > HNS3_RXD_VLD_B has been set. Driver needs to add rmb() instruction
> > to make sure desc->rx.size is always valid.
> >
> > Fixes: e55970950556 ("net: hns3: Add handling of GRO Pkts not fully RX'ed in NAPI poll")
> > Signed-off-by: Jian Shen <shenjian15@xxxxxxxxxx>
> > Signed-off-by: Huazhong Tan <tanhuazhong@xxxxxxxxxx>
>
> dma_rmb() is more appropriate here and more efficient.

Thanks, will send V2  to fix it.

> .