Re: [PATCH] x86/ftrace: avoid an unused-function warning

From: Arnd Bergmann
Date: Tue Mar 05 2019 - 02:52:45 EST

On Mon, Mar 4, 2019 at 10:43 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Mon, 4 Mar 2019 21:07:39 +0100 Arnd Bergmann <arnd@xxxxxxxx> wrote:
> Also, it's basically identical to ftrace_call_replace(). I'm going to
> combine the two and move the jmp replace and have it do this instead.

Sounds good.

> arch/x86/kernel/ftrace.c:669:23: error: 'ftrace_jmp_replace' defined but not used [-Werror=unused-function]
> The ftrace_jmp_replace() function now only has a single user and should be
> simply moved by that user. But looking at the code, it shows that
> ftrace_jmp_replace() is similar to ftrace_call_replace() except that instead
> of using the opcode of 0xe8 it uses 0xe9. It makes more sense to consolidate
> that function into one implementation that both ftrace_jmp_replace() and
> ftrace_call_replace() use by passing in the op code separate.
> The structure in ftrace_code_union is also modified to replace the "e8"
> field with the more appropriate name "op".
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> Link:
> Fixes: d2a68c4effd8 ("x86/ftrace: Do not call function graph from dynamic trampolines")
> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>