Re: [PATCH] [v2] media: staging/intel-ipu3: reduce kernel stack usage

[Sakari Ailus]

On Tue, Mar 05, 2019 at 02:26:29PM +0100, Arnd Bergmann wrote:
> The imgu_css_queue structure is too large to be put on the kernel
> stack, as we can see in 32-bit builds:
> 
> drivers/staging/media/ipu3/ipu3-css.c: In function 'imgu_css_fmt_try':
> drivers/staging/media/ipu3/ipu3-css.c:1863:1: error: the frame size of 1172 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> 
> By dynamically allocating this array, the stack usage goes down to an
> acceptable 140 bytes for the same x86-32 configuration.
> 
> Fixes: f5f2e4273518 ("media: staging/intel-ipu3: Add css pipeline programming")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> v2: restructure to use 'return -ENOMEM' instead of goto for failed
>     allocation.

Thanks, Arnd! All three applied.

-- 
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx