Re: [PATCH v3] RDMA/umem: minor bug fix in error handling path

[Leon Romanovsky]

On Tue, Mar 05, 2019 at 05:04:06PM +0200, Yuval Shaia wrote:
> On Mon, Mar 04, 2019 at 03:58:15AM -0800, Ira Weiny wrote:
> > On Mon, Mar 04, 2019 at 11:46:45AM -0800, john.hubbard@xxxxxxxxx wrote:
> > > From: John Hubbard <jhubbard@xxxxxxxxxx>
> > >
> > > 1. Bug fix: fix an off by one error in the code that
> > > cleans up if it fails to dma-map a page, after having
> > > done a get_user_pages_remote() on a range of pages.
> > >
> > > 2. Refinement: for that same cleanup code, release_pages()
> > > is better than put_page() in a loop.
> > >
> > > Cc: Leon Romanovsky <leon@xxxxxxxxxx>
> > > Cc: Ira Weiny <ira.weiny@xxxxxxxxx>
> > > Cc: Jason Gunthorpe <jgg@xxxxxxxx>
> > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > Cc: Doug Ledford <dledford@xxxxxxxxxx>
> > > Cc: linux-rdma@xxxxxxxxxxxxxxx
> > > Cc: linux-mm@xxxxxxxxx
> > > Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
> >
> > I meant...
> >
> > Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>
> >
> > <sigh>  just a bit too quick on the keyboard before lunch...  ;-)
> >
> > Ira
>
> I have this mapping in vimrc so i just have to do shift+!
>
> map ! o
Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>


I have something similar, but limited to responses through mail client only
and mapped to "rt" key combination.

in my .vimrc:

augroup filetypedetect
	" Mail
	autocmd BufRead,BufNewFile *mutt-* setfiletype mail
	 " Add Reviewed-by tag and delete rest of the email
	function! RBtag()
		r~/.vim/mutt/rb-tag.txt
	endfunction
	nmap rt :call RBtag()<CR>2j<CR>dG<CR>
augroup END

Thanks

Attachment: signature.asc
Description: PGP signature