Re: [PATCH] x86: Deprecate a.out support
From: Borislav Petkov
Date: Tue Mar 05 2019 - 12:31:40 EST
On Tue, Mar 05, 2019 at 08:22:21AM -0800, Linus Torvalds wrote:
> Because I think all the known *bugs* we had were with the core dumping
> code, weren't they?
Well, I'm aware of only this one I fixed but who knows what else has
bitrotten out there through the years...
> Removing it looks trivial. Untested patch attached.
> Then I'd be much happier with your "let's deprecate a.out entirely" as
> a second patch, because I think it's a unrelated issue and much more
> likely to have somebody pipe up and say "hey, I have this sequence
> that generates executables dynamically, and I use a.out because it's
> much simpler than ELF, and now it's broken". Or something.
Hohumm, yap, it all makes sense to me. That's definitely the safer
approach without us having to revert patches later.
So how do you wanna handle this?
I guess the easiest would be if you apply your patch directly now and
add the a.out phase-out strategy we're going for in its commit message
so that people are aware of what we're doing.
This will allow for other arch maintainers to delete
arch/*/include/asm/a.out-core.h, Jann mentions in the other mail, after
-rc1 is cut.
And then I'll carry any other patches through the tip tree ontop of -rc1
Good mailing practices for 400: avoid top-posting and trim the reply.