Re: [PATCH for 5.1 0/3] Restartable Sequences updates for 5.1
From: Mathieu Desnoyers
Date: Tue Mar 05 2019 - 17:32:15 EST
----- On Mar 5, 2019, at 4:58 PM, Peter Zijlstra peterz@xxxxxxxxxxxxx wrote:
> On Tue, Mar 05, 2019 at 03:18:35PM -0500, Mathieu Desnoyers wrote:
>> * NUMA node ID in TLS
>> Having the NUMA node ID available in a TLS variable would allow glibc to
>> perform interesting NUMA performance improvements within its locking
>> implementation, so I have a patch adding NUMA node ID support to rseq
>> as a new rseq system call flag.
> Details? There's just not much room in the futex word, and futexes
> themselves are not numa aware.
It was discussed in this libc-alpha mailing list thread:
(adding the relevant people in CC)
I'd like to hear in more details on how they intend to design
NUMA-aware spinlocks within glibc. All I know is that quick
access to the node ID would help for this.
I would suspect we could split a lock into per-numa-node locks.
Grabbing the local numa lock would then allow grabbing the global
lock. This should help reducing remote NUMA accesses on the global
lock in contended cases, but I'm really just guessing here.
> Before all this spectre nonsense; tglx and me were looking at a futex2
> syscall that would, among other things, cure this.
The email thread I point to above talks about "spinlocks", so I'm not
sure whether their intent is to apply this to mutexes as well.
>> * Adaptative mutex improvements
>> I have done a prototype using rseq to implement an adaptative mutex which
>> can detect preemption using a rseq critical section. This ensures the
>> thread doesn't continue to busy-loop after it returns from preemption, and
>> calls sys_futex() instead. This is part of a user-space prototype branch ,
>> and does not require any kernel change.
> I'm still not convinced that is actually the right way to go about
> things. The kernel heuristic is spin while the _owner_ runs, and we
> don't get preempted, obviously.
> And the only userspace spinning that makes sense is to cover the cost of
> the syscall. Now Obviously PTI wrecked everything, but before that
> syscalls were actually plenty fast and you didn't need many cmpxchg
> cycles to amortize the syscall itself -- which could then do kernel side
> adaptive spinning (when required).
Indeed with PTI the system calls are back to their slow self. ;)
You point about owner is interesting. Perhaps there is one tweak that I
should add in there. We could write the owner thread ID in the lock word.
When trying to grab a lock, one of a few situations can happen:
- It's unlocked, so we grab it by storing our thread ID,
- It's locked, and we can fetch the CPU number of the thread owning it
if we can access its (struct rseq *)->cpu_id through a lookup using its
thread ID, We can then check whether it's the same CPU we are running on.
- If so, we _know_ we should let the owner run, so we call futex right away,
no spinning. We can even boost it for priority inheritance mutexes,
- If it's owned by a thread which was last running on a different CPU,
then it may make sense to actively try to grab the lock by spinning
up to a certain number of loops (which can be either fixed or adaptative).
After that limit, call futex. If preempted while looping, call futex.
Do you see this as an improvement over what exists today, or am I
on the wrong track ?