Re: [PATCH 2/2] ARM: drop -mauto-it

[Stefan Agner]

On 05.03.2019 23:21, Nick Desaulniers wrote:
> On Tue, Mar 5, 2019 at 2:17 PM Stefan Agner <stefan@xxxxxxxx> wrote:
>>
>> The assembler option -mauto-it is no longer a valid option. It has
>> been removed from the documentation in July 2009, which is well
>> before the release date of the currently supported binutils version
>> 2.20.
> 
> Do you by chance have a link to the relevant commit?
> 

Documentation got removed in
https://github.com/bminor/binutils-gdb/commit/529707530657a333a304c651c808ea630c955223

I think -mauto-it never really made it upstream. Documentation has been
introduced here, but it seems that the option already has been renamed:
https://github.com/bminor/binutils-gdb/commit/e07e6e58be1c5273ed79a25c80ba831e71ac86b1

>>
>> Signed-off-by: Stefan Agner <stefan@xxxxxxxx>
>> ---
>>  arch/arm/Makefile | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
>> index 9561325c5201..ebf67bebe73d 100644
>> --- a/arch/arm/Makefile
>> +++ b/arch/arm/Makefile
>> @@ -113,8 +113,7 @@ CFLAGS_ABI  +=-funwind-tables
>>  endif
>>
>>  ifeq ($(CONFIG_THUMB2_KERNEL),y)
>> -AFLAGS_AUTOIT  :=$(call as-option,-Wa$(comma)-mimplicit-it=always,-Wa$(comma)-mauto-it)
>> -CFLAGS_ISA     :=-mthumb $(AFLAGS_AUTOIT)
>> +CFLAGS_ISA     :=-mthumb -Wa$(comma)-mimplicit-it=always
> 
> Is $(comma) still needed? I thought it was only needed when a flag
> that would contain commas would be in another set of parens (thus
> making an ambiguity), like cc-ldoption or such?  Can you replace
> `$(comma)` here with `,`?  I suspect it should work.

Could catch, yes comma should work here.

--
Stefan