Re: [PATCH] net/sched: avoid unused-label warning

[Cong Wang]

On Mon, Mar 4, 2019 at 12:40 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> The label is only used from inside the #ifdef and should be
> hidden the same way, to avoid this warning:
>
> net/sched/act_tunnel_key.c: In function 'tunnel_key_init':
> net/sched/act_tunnel_key.c:389:1: error: label 'release_tun_meta' defined but not used [-Werror=unused-label]
>  release_tun_meta:
>
> Fixes: 41411e2fd6b8 ("net/sched: act_tunnel_key: Add dst_cache support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>  net/sched/act_tunnel_key.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sched/act_tunnel_key.c b/net/sched/act_tunnel_key.c
> index 2a5f215ae876..3beb4717d3b7 100644
> --- a/net/sched/act_tunnel_key.c
> +++ b/net/sched/act_tunnel_key.c
> @@ -392,8 +392,8 @@ static int tunnel_key_init(struct net *net, struct nlattr *nla,
>  #ifdef CONFIG_DST_CACHE
>         if (metadata)
>                 dst_cache_destroy(&metadata->u.tun_info.dst_cache);
> -#endif
>  release_tun_meta:
> +#endif

These #ifdef's are ugly, either we should select DST_CACHE
or provide a nop for these dst_cache_*() APIs when it is not
enabled.