Re: [PATCH v12 3/4] pstore/blk: support pmsg for pstore block

[Randy Dunlap]

Hi,

On 2/27/19 11:12 PM, liaoweixiong wrote:
> diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig
> index 7dfe00b..b417bf5 100644
> --- a/fs/pstore/Kconfig
> +++ b/fs/pstore/Kconfig
> @@ -210,6 +210,27 @@ config PSTORE_BLKOOPS_DMESG_SIZE
>  	     It is the first priority. Take care of that blkoops will take lower
>  	     priority settings if higher priority one do not set.
>  
> +config PSTORE_BLKOOPS_PMSG_SIZE
> +	int "pmsg size in kbytes for blkoops"
> +	depends on PSTORE_BLKOOPS
> +	default 64
> +	help
> +	  This just sets size of pmsg (pmsg_size) for pstore/blk. The value must
> +	  be a multiple of 4096. Pmsg work only if "blkdev" is set.

	                              works

> +
> +	  NOTE that, there are three ways to set parameters of blkoops and
> +	  prioritize according to configuration flexibility. That is
> +	  Kconfig < device tree < module parameters. It means that the value can
> +	  be overwritten by higher priority settings.
> +	  1. Kconfig
> +	     It	just sets a default value.
> +	  2. device tree
> +	     It is set on device tree, which will overwrites value from Kconfig,

	                                          overwrite the value from Kconfig,

> +	     but can also be overwritten by module parameters.
> +	  3. module parameters
> +	     It is the first priority. Take care of that blkoops will take lower
> +	     priority settings if higher priority one do not set.
> +
>  config PSTORE_BLKOOPS_TOTAL_SIZE
>  	int "total size in kbytes for blkoops"
>  	depends on PSTORE_BLKOOPS

cheers.
-- 
~Randy