Re: [PATCH 08/14] Move EM_NDS32 to uapi/linux/elf-em.h
From: Greentime Hu
Date: Wed Mar 06 2019 - 01:28:37 EST
Vincent Chen <deanbo422@xxxxxxxxx> æ 2019å3æ5æ éä äå8:26åéï
>
> Dmitry V. Levin <ldv@xxxxxxxxxxxx> æ 2019å2æ27æ éä äå11:30åéï
>
>
> >
> > This should never have been defined in the arch tree to begin with,
> > and now uapi/linux/audit.h header is going to use EM_NDS32
> > in order to define AUDIT_ARCH_NDS32 which is needed to implement
> > syscall_get_arch() which in turn is required to extend
> > the generic ptrace API with PTRACE_GET_SYSCALL_INFO request.
> >
> > Acked-by: Paul Moore <paul@xxxxxxxxxxxxxx>
> > Cc: Greentime Hu <green.hu@xxxxxxxxx>
> > Cc: Vincent Chen <deanbo422@xxxxxxxxx>
> > Cc: Elvira Khabirova <lineprinter@xxxxxxxxxxxx>
> > Cc: Eugene Syromyatnikov <esyr@xxxxxxxxxx>
> > Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
> > Cc: Andy Lutomirski <luto@xxxxxxxxxx>
> > Cc: linux-audit@xxxxxxxxxx
> > Signed-off-by: Dmitry V. Levin <ldv@xxxxxxxxxxxx>
> > ---
> > This is just a gentle ping, the patch is unchanged.
> >
> > arch/nds32/include/asm/elf.h | 3 +--
> > include/uapi/linux/elf-em.h | 2 ++
> > 2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/nds32/include/asm/elf.h b/arch/nds32/include/asm/elf.h
> > index 95f3ea253e4c..02250626b9f0 100644
> > --- a/arch/nds32/include/asm/elf.h
> > +++ b/arch/nds32/include/asm/elf.h
> > @@ -10,14 +10,13 @@
> >
> > #include <asm/ptrace.h>
> > #include <asm/fpu.h>
> > +#include <linux/elf-em.h>
> >
> > typedef unsigned long elf_greg_t;
> > typedef unsigned long elf_freg_t[3];
> >
> > extern unsigned int elf_hwcap;
> >
> > -#define EM_NDS32 167
> > -
> > #define R_NDS32_NONE 0
> > #define R_NDS32_16_RELA 19
> > #define R_NDS32_32_RELA 20
> > diff --git a/include/uapi/linux/elf-em.h b/include/uapi/linux/elf-em.h
> > index bd02325028d8..4b8df722330e 100644
> > --- a/include/uapi/linux/elf-em.h
> > +++ b/include/uapi/linux/elf-em.h
> > @@ -40,6 +40,8 @@
> > #define EM_ALTERA_NIOS2 113 /* Altera Nios II soft-core processor */
> > #define EM_TI_C6000 140 /* TI C6X DSPs */
> > #define EM_HEXAGON 164 /* QUALCOMM Hexagon */
> > +#define EM_NDS32 167 /* Andes Technology compact code size
> > + embedded RISC processor family */
> > #define EM_AARCH64 183 /* ARM 64 bit */
> > #define EM_TILEPRO 188 /* Tilera TILEPro */
> > #define EM_MICROBLAZE 189 /* Xilinx MicroBlaze */
> > --
> > ldv
>
> Thanks for fixing this.
>
> Acked-by Vincent Chen
Thank you. I add his email address. :P
Acked-by: Vincent Chen <vincentc@xxxxxxxxxxxxx>
Acked-by: Greentime Hu <greentime@xxxxxxxxxxxxx>