RE: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

From: Ryan Pannell
Date: Wed Mar 06 2019 - 05:18:26 EST


Jagan,

The compatible is for the real hardware name as Maxime previously explained. The platform is described in the latter part.
Please use:
compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";

Thanks,
Ryan Pannell
Development Team Lead
Oceanic Systems (UK) Ltd

-----Original Message-----
From: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
Sent: 06 March 2019 09:36
To: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>
Cc: Ryan Pannell <ryan@xxxxxxxxx>; Chen-Yu Tsai <wens@xxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx>; linux-arm-kernel <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; devicetree <devicetree@xxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>; linux-amarula@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

On Wed, Mar 6, 2019 at 2:57 PM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote:
>
> On Tue, Mar 05, 2019 at 04:35:04PM +0000, Ryan Pannell wrote:
> > We don't mind if it has to be:
> > compatible = "oceanic,5inmfd", "allwinner,sun50i-a64";
> >
> > However, to avoid confusion, might it be worth including the part number (We list this as '5205 5" MFD') so this would become:
> > compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";
> >
> > Perhaps this solves the issue. Please let me know thoughts.
>
> Yep, that works for me

A64 instead of part-number 5205 seems less confused isn't it? or we need to give more priority with real hardware definition?