Re: [PATCH 1/2] appletalk: Fix compile regression

From: David Miller
Date: Wed Mar 06 2019 - 13:47:18 EST


From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Wed, 6 Mar 2019 11:52:36 +0100

> A bugfix just broke compilation of appletalk when CONFIG_SYSCTL
> is disabled:
>
> In file included from net/appletalk/ddp.c:65:
> net/appletalk/ddp.c: In function 'atalk_init':
> include/linux/atalk.h:164:34: error: expected expression before 'do'
> #define atalk_register_sysctl() do { } while(0)
> ^~
> net/appletalk/ddp.c:1934:7: note: in expansion of macro 'atalk_register_sysctl'
> rc = atalk_register_sysctl();
>
> This is easier to avoid by using conventional inline functions
> as stubs rather than macros. The header already has inline
> functions for other purposes, so I'm changing over all the
> macros for consistency.
>
> Fixes: 6377f787aeb9 ("appletalk: Fix use-after-free in atalk_proc_exit")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Applied.