Re: [RFC][Patch v9 0/6] KVM: Guest Free Page Hinting

[David Hildenbrand]

On 06.03.19 19:43, Michael S. Tsirkin wrote:
> On Wed, Mar 06, 2019 at 01:30:14PM -0500, Nitesh Narayan Lal wrote:
>>>> Here are the results:
>>>>
>>>> Procedure: 3 Guests of size 5GB is launched on a single NUMA node with
>>>> total memory of 15GB and no swap. In each of the guest, memhog is run
>>>> with 5GB. Post-execution of memhog, Host memory usage is monitored by
>>>> using Free command.
>>>>
>>>> Without Hinting:
>>>> ÂÂÂ ÂÂÂÂ ÂÂÂ ÂÂÂ Time of executionÂÂÂ Host used memory
>>>> Guest 1:ÂÂÂ ÂÂÂ 45 secondsÂÂÂ ÂÂÂ ÂÂÂ 5.4 GB
>>>> Guest 2:ÂÂ ÂÂ Â 45 secondsÂÂÂ ÂÂ ÂÂ Â 10 GB
>>>> Guest 3:ÂÂÂ ÂÂÂ 1Â minuteÂÂÂ ÂÂ ÂÂ ÂÂÂÂ 15 GB
>>>>
>>>> With Hinting:
>>>> ÂÂÂ ÂÂÂ ÂÂÂ Â Â Time of execution ÂÂÂ Host used memory
>>>> Guest 1:ÂÂ ÂÂ Â 49 secondsÂÂÂ ÂÂÂ ÂÂÂ 2.4 GB
>>>> Guest 2:ÂÂ ÂÂ Â 40 secondsÂÂÂ ÂÂ ÂÂ Â 4.3 GB
>>>> Guest 3:ÂÂÂ ÂÂÂ 50 secondsÂÂÂ ÂÂÂ ÂÂÂ 6.3 GB
>>> OK so no improvement.
>> If we are looking in terms of memory we are getting back from the guest,
>> then there is an improvement. However, if we are looking at the
>> improvement in terms of time of execution of memhog then yes there is none.
> 
> Yes but the way I see it you can't overcommit this unused memory
> since guests can start using it at any time.  You timed it carefully
> such that this does not happen, but what will cause this timing on real
> guests?

Whenever you overcommit you will need backup swap. There is no way
around it. It just makes the probability of you having to go to disk
less likely.

If you assume that all of your guests will be using all of their memory
all the time, you don't have to think about overcommiting memory in the
first place. But this is not what we usually have.

> 
> So the real reason to want this is to avoid need for writeback on free
> pages.
> 
> Right?

-- 

Thanks,

David / dhildenb