Re: [PATCH v4 01/15] perf tools: Add utility function to fetch executable

From: Andi Kleen
Date: Wed Mar 06 2019 - 16:08:34 EST


> . No need to cast around, make 'buf' be a void pointer
>
> . Rename it to thread__memcpy() to reflect the fact it is about copying
> a chunk of memory from a thread, i.e. from its address space.
>
> . No need to have it in a separate object file, move it to thread.[ch]
>
> . Check the return of map__load(), the original code didn't do it, but
> since we're moving this around, check that as well, could be moved to
> a separate patch tho.

Changes look good. Thanks Arnaldo.

-Andi