Re: [PATCH v5 03/10] perf session: define bytes_transferred and bytes_compressed metrics

[Alexey Budankov]

On 05.03.2019 15:26, Jiri Olsa wrote:
> On Fri, Mar 01, 2019 at 06:43:28PM +0300, Alexey Budankov wrote:
>>
>> Define bytes_transferred and bytes_compressed metrics to calculate
>> comp_ratio=transferred/compressed in the end of the data collection.
>>
>> bytes_transferred accumulates the amount of bytes that was extracted from
>> the mmaped kernel buffers for compression. bytes_compressed accumulates
>> the amount of bytes that was received after applying compression to
>> move to a storage.
>>
>> Signed-off-by: Alexey Budankov <alexey.budankov@xxxxxxxxxxxxxxx>
>> ---
>>  tools/perf/builtin-record.c | 8 ++++++++
>>  tools/perf/util/env.h       | 1 +
>>  tools/perf/util/session.h   | 2 ++
>>  3 files changed, 11 insertions(+)
>>
>> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
>> index 9b02a68e8c23..ab121bc27c6d 100644
>> --- a/tools/perf/builtin-record.c
>> +++ b/tools/perf/builtin-record.c
>> @@ -1449,6 +1449,14 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
>>  	record__mmap_read_all(rec, true);
>>  	record__aio_mmap_read_sync(rec);
>>  
>> +	if (!quiet && rec->session->bytes_transferred && rec->session->bytes_compressed) {
>> +		float ratio = (float)rec->session->bytes_transferred/(float)rec->session->bytes_compressed;
>> +
>> +		session->header.env.comp_ratio = ratio + 0.5;
> 
> what's the + 0.5 for?

Arithmetic rounding before type cast.

> 
>> +		fprintf(stderr,	"[ perf record: Compressed %.3f MB to %.3f MB, ratio is %.3f ]\n",
>> +			rec->session->bytes_transferred / 1024.0 / 1024.0, rec->session->bytes_compressed / 1024.0 / 1024.0, ratio);
>> +	}
>> +
> 
> could this be below together with the current:
> 
> 	fprintf(stderr, "[ perf record: Captured and wrote %.3f MB %s%s%s ]\n",

Please provide an example of what you exactly mean.

~Alexey

> 
> thanks,
> jirka
> 
>>  	if (forks) {
>>  		int exit_status;
>>  
>> diff --git a/tools/perf/util/env.h b/tools/perf/util/env.h
>> index d01b8355f4ca..fb39e9af128f 100644
>> --- a/tools/perf/util/env.h
>> +++ b/tools/perf/util/env.h
>> @@ -64,6 +64,7 @@ struct perf_env {
>>  	struct memory_node	*memory_nodes;
>>  	unsigned long long	 memory_bsize;
>>  	u64                     clockid_res_ns;
>> +	u32                     comp_ratio;
>>  };
>>  
>>  extern struct perf_env perf_env;
>> diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h
>> index d96eccd7d27f..0e14884f28b2 100644
>> --- a/tools/perf/util/session.h
>> +++ b/tools/perf/util/session.h
>> @@ -35,6 +35,8 @@ struct perf_session {
>>  	struct ordered_events	ordered_events;
>>  	struct perf_data	*data;
>>  	struct perf_tool	*tool;
>> +	u64			bytes_transferred;
>> +	u64			bytes_compressed;
>>  };
>>  
>>  struct perf_tool;
>> -- 
>> 2.20.1
>>
>