Re: [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula

From: Pierre Yves MORDRET
Date: Thu Mar 07 2019 - 03:30:19 EST


Hi

Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@xxxxxx>

Thanks

On 3/6/19 4:12 PM, Bich HEMON wrote:
> From: Nicolas Le Bayon <nicolas.le.bayon@xxxxxx>
>
> It conforms with Reference Manual I2C timing section.
>
> Signed-off-by: Nicolas Le Bayon <nicolas.le.bayon@xxxxxx>
> Signed-off-by: Bich Hemon <bich.hemon@xxxxxx>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 13e1213..4284fc9 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -432,7 +432,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev,
> STM32F7_I2C_ANALOG_FILTER_DELAY_MAX : 0);
> dnf_delay = setup->dnf * i2cclk;
>
> - sdadel_min = setup->fall_time - i2c_specs[setup->speed].hddat_min -
> + sdadel_min = i2c_specs[setup->speed].hddat_min + setup->fall_time -
> af_delay_min - (setup->dnf + 3) * i2cclk;
>
> sdadel_max = i2c_specs[setup->speed].vddat_max - setup->rise_time -
>