Re: [PATCH v4 4/8] drivers: devfreq: add DMC driver for Exynos5422

[Sylwester Nawrocki]

Hi Chanwoo,

On 3/7/19 02:10, Chanwoo Choi wrote:
> This patch has the another quetion about the clocks in
> exynos5_dmc_init_clks(). This functions used 'clk_set_parent'
> to make the hierarchy between clocks. I think it is possible to make
> the relation of clocks in DT by using the 'assigned-clocks'.

I'm fine either way, AFAICS it is a matter of setting parent of just
one clock - "mout_mx_mspll_ccore".  The driver needs to get that clock
anyway to enable/disable it as required.  So we will not gain much from
using assigned-clocks I'd say. I don't really have a strong opinion here
as I don't know detailed requirements of the DMC clock configuration
sequence. I'm inclined to keep it in driver as it would be more flexible.

-- 
Regards,
Sylwester