Re: [PATCH] ethtool: reduce stack usage with clang

[Arnd Bergmann]

On Thu, Mar 7, 2019 at 11:06 AM Michal Kubecek <mkubecek@xxxxxxx> wrote:
>
> On Thu, Mar 07, 2019 at 10:33:35AM +0100, Arnd Bergmann wrote:

> > @@ -2533,7 +2535,7 @@ static int ethtool_set_fecparam(struct net_device *dev, void __user *useraddr)
> >
> >  /* The main entry point in this file.  Called from net/core/dev_ioctl.c */
> >
> > -int dev_ethtool(struct net *net, struct ifreq *ifr)
> > +int noinline_for_stack dev_ethtool(struct net *net, struct ifreq *ifr)
> >  {
> >       struct net_device *dev = __dev_get_by_name(net, ifr->ifr_name);
> >       void __user *useraddr = ifr->ifr_data;
>
> Is this part really needed? AFAICS dev_ethtool() is only called from
> dev_ioctl() which is in a different compilation unit so that
> dev_ethtool() won't be inlined anyway.

No, you are right. I had accidentally left this in place from an earlier
version. Sending a v2 now.

      Arnd