Re: [PATCH 18/20] objtool: Add UACCESS validation

From: hpa
Date: Thu Mar 07 2019 - 12:12:17 EST

On March 7, 2019 8:33:26 AM PST, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>On Thu, Mar 7, 2019 at 3:52 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>> XXX: are we sure we want __memset marked AC-safe?
>It's certainly one of the safer functions to call with AC set, but it
>sounds wrong anyway. It's not like it's likely to leak kernel data
>(most memset's are with 0, and even the non-zero ones I can't imagine
>are sensitive - more like poison values etc).
>What's the call site that made you go "just add __memset() to the
> Linus

Agreed... it seems fishy at least.

Sent from my Android device with K-9 Mail. Please excuse my brevity.