Re: [PATCH] proc: test with vsyscall in mind

From: Andrew Morton
Date: Thu Mar 07 2019 - 14:01:05 EST


On Thu, 7 Mar 2019 21:32:04 +0300 Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:

> Read from vsyscall page to tell if vsyscall is being used.
>
> Reported-by: kernel test robot
> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>

There's a lot of information missing from this changelog :(


I rewrote it to this:

: selftests: proc: proc-pid-vm
: ========================================
: proc-pid-vm: proc-pid-vm.c:277: main: Assertion `rv == strlen(buf0)' failed.
: Aborted

Because the vsyscall mapping is enabled. Read from vsyscall page to tell
if vsyscall is being used.

Link: 20190307183204.GA11405@avx2">http://lkml.kernel.org/r/20190307183204.GA11405@avx2
Link: http://lkml.kernel.org/r/20190219094722.GB28258@shao2-debian
Fixes: 34aab6bec23e7e9 ("proc: test /proc/*/maps, smaps, smaps_rollup, statm")
Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Reported-by: kernel test robot <rong.a.chen@xxxxxxxxx>
Cc: Shuah Khan <shuah@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>