RE: [PATCH v2] arm64: dts: ls1088a: add one more thermal zone node

[Andy Tang]

> -----Original Message-----
> From: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Sent: 2019年3月7日 17:15
> To: Andy Tang <andy.tang@xxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: Leo Li <leoyang.li@xxxxxxx>; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; rui.zhang@xxxxxxxxx;
> edubezval@xxxxxxxxx
> Subject: Re: [PATCH v2] arm64: dts: ls1088a: add one more thermal zone node
> 
> >>> PS: In order to keep consistency to the first thermal-zone node,
> >>> there will be "WARNING: line over 80 characters" warnings.
> >>>
> >>>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi |   43
> >> +++++++++++++++++++++--
> >>>  1 files changed, 39 insertions(+), 4 deletions(-)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> >>> b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> >>> index 661137f..9f52bc9 100644
> >>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> >>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> >>> @@ -129,19 +129,19 @@
> >>>  	};
> >>>
> >>>  	thermal-zones {
> >>> -		cpu_thermal: cpu-thermal {
> >>> +		ccu {
> >>
> >> Is this change really necessary?  What does 'ccu' stand for?
> > I think so. ccu stands for core cluster unit. cpu is too general.
> > On some platforms, there are more than one core clusters.
> > At least we should change it to "core cluster" if short form is not appropriate.
> 
> If the sensor is a the cluster level, 'cluster' is enough. IMHO, no need to give a
> description of what contains the cluster, otherwise you will end up with a
> 'core-gpu-cluster-l2' name.
If cluster is specific to core, we can use cluster instead. But I don't think so.
Cluster may refer to "core cluster", "GPU cluster" etc.
So, I think "core-cluster" is ok.
If core was divided to several clusters, we can name it as "core-cluster1", "core-cluster2" etc.
If GPU was divided to several clusters we can name it as "gpu-cluster1", "gpu-cluster2" etc. 

BR,
Andy
> 
> >>
> >>>  			polling-delay-passive = <1000>;
> >>>  			polling-delay = <5000>;
> >>>  			thermal-sensors = <&tmu 0>;
> >>>
> >>>  			trips {
> >>> -				cpu_alert: cpu-alert {
> >>> +				ccu_alert: ccu-alert {
> >>>  					temperature = <85000>;
> >>>  					hysteresis = <2000>;
> >>>  					type = "passive";
> >>>  				};
> >>>
> >>> -				cpu_crit: cpu-crit {
> >>> +				ccu_crit: ccu-crit {
> >>>  					temperature = <95000>;
> >>>  					hysteresis = <2000>;
> >>>  					type = "critical";
> >>> @@ -150,7 +150,42 @@
> >>>
> >>>  			cooling-maps {
> >>>  				map0 {
> >>> -					trip = <&cpu_alert>;
> >>> +					trip = <&ccu_alert>;
> >>> +					cooling-device =
> >>> +						<&cpu0 THERMAL_NO_LIMIT
> >> THERMAL_NO_LIMIT>,
> >>> +						<&cpu1 THERMAL_NO_LIMIT
> >> THERMAL_NO_LIMIT>,
> >>> +						<&cpu2 THERMAL_NO_LIMIT
> >> THERMAL_NO_LIMIT>,
> >>> +						<&cpu3 THERMAL_NO_LIMIT
> >> THERMAL_NO_LIMIT>,
> >>> +						<&cpu4 THERMAL_NO_LIMIT
> >> THERMAL_NO_LIMIT>,
> >>> +						<&cpu5 THERMAL_NO_LIMIT
> >> THERMAL_NO_LIMIT>,
> >>> +						<&cpu6 THERMAL_NO_LIMIT
> >> THERMAL_NO_LIMIT>,
> >>> +						<&cpu7 THERMAL_NO_LIMIT
> >> THERMAL_NO_LIMIT>;
> >>> +				};
> >>> +			};
> >>> +		};
> >>> +
> >>> +		plt {
> >>
> >> What about 'platform-thermal' for node name, platform-alert and
> >> platform-crit for trip nodes below?
> > OK, will use long name form.
> >
> > BR,
> > Andy
> >>
> >> Shawn
> >>
> >>> +			polling-delay-passive = <1000>;
> >>> +			polling-delay = <5000>;
> >>> +			thermal-sensors = <&tmu 1>;
> >>> +
> >>> +			trips {
> >>> +				plt_alert: plt-alert {
> >>> +					temperature = <85000>;
> >>> +					hysteresis = <2000>;
> >>> +					type = "passive";
> >>> +				};
> >>> +
> >>> +				plt_crit: plt-crit {
> >>> +					temperature = <95000>;
> >>> +					hysteresis = <2000>;
> >>> +					type = "critical";
> >>> +				};
> >>> +			};
> >>> +
> >>> +			cooling-maps {
> >>> +				map0 {
> >>> +					trip = <&plt_alert>;
> >>>  					cooling-device =
> >>>  						<&cpu0 THERMAL_NO_LIMIT
> >> THERMAL_NO_LIMIT>,
> >>>  						<&cpu1 THERMAL_NO_LIMIT
> >> THERMAL_NO_LIMIT>,
> >>> --
> >>> 1.7.1
> >>>
> 
> 
> --
> 
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.l
> inaro.org%2F&amp;data=02%7C01%7Candy.tang%40nxp.com%7C59738105e23
> 2436e0c8808d6a2dd583b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C636875468882120357&amp;sdata=jxYXYhc3Tc407a10WgOcbyIX7OCl1eScoJ
> deutX%2Btnk%3D&amp;reserved=0> Linaro.org │ Open source software for
> ARM SoCs
> 
> Follow Linaro:
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> facebook.com%2Fpages%2FLinaro&amp;data=02%7C01%7Candy.tang%40nxp.c
> om%7C59738105e232436e0c8808d6a2dd583b%7C686ea1d3bc2b4c6fa92cd99c5
> c301635%7C0%7C0%7C636875468882120357&amp;sdata=vikEm7YrV%2F8RvQ
> %2FGsXh3O361HZR3RqDcdvq4uTgB58w%3D&amp;reserved=0> Facebook |
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitte
> r.com%2F%23!%2Flinaroorg&amp;data=02%7C01%7Candy.tang%40nxp.com%7
> C59738105e232436e0c8808d6a2dd583b%7C686ea1d3bc2b4c6fa92cd99c5c3016
> 35%7C0%7C0%7C636875468882120357&amp;sdata=dBdCgFfsO6uFS%2FLl5lNH
> aYB2mOredm9Wdtf1aWT8Si8%3D&amp;reserved=0> Twitter |
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.l
> inaro.org%2Flinaro-blog%2F&amp;data=02%7C01%7Candy.tang%40nxp.com%7
> C59738105e232436e0c8808d6a2dd583b%7C686ea1d3bc2b4c6fa92cd99c5c3016
> 35%7C0%7C0%7C636875468882120357&amp;sdata=FCbdkbwdUPVyCjPdxcU5U
> gUfFVZzMExdaOpsZD3SCmQ%3D&amp;reserved=0> Blog