Re: [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc
From: Pavel Machek
Date: Thu Mar 14 2019 - 05:39:18 EST
Hi!
Could you maybe slow down a bit.
"Hey, I should review this". "Hmm, there are two new versions in the
mailbox in the meantime, good thing I waited."
> + ramp-up-ms = <1024>;
> + ramp-down-ms = <65536>;
This is wrong.
> + led@1 {
> + reg = <1>;
> + led-sources = <1>;
> + ti,led-mode = <0>;
> + label = "keypad";
"platform::kbd_backlight"
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature