Re: [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc

[Dan Murphy]

Hello

On 3/14/19 4:39 AM, Pavel Machek wrote:
> Hi!
> 
> Could you maybe slow down a bit.
> 
> "Hey, I should review this". "Hmm, there are two new versions in the
> mailbox in the meantime, good thing I waited."
> 

Yes.  I am going to hold off on v5 until the code gets reviewed.

>> +	ramp-up-ms = <1024>;
>> +	ramp-down-ms = <65536>;
> 
> This is wrong.
> 

Ack.  Changed in it in the example I deleted.

>> +	led@1 {
>> +		reg = <1>;
>> +		led-sources = <1>;
>> +		ti,led-mode = <0>;
>> +		label = "keypad";
> 
> "platform::kbd_backlight"

Being an example does it have to match DT contents?

I can change it since I have to touch the file anyway.

Dan


> 									Pavel
> 


-- 
------------------
Dan Murphy