Re: [REGRESSION] failed to boot: commit 1aec4211204d parport: daisy: use new parport device model
From: Linus Torvalds
Date: Mon Mar 25 2019 - 14:05:11 EST
On Mon, Mar 25, 2019 at 8:36 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> I bisected it down to this commit:
>
> aec4211204d ("parport: daisy: use new parport device model")
I was confused, because no such commit exists.
But it turns out you have the right commit ID in your subject line,
and you just dropped the initial '1' .
Anyway, that commit does look odd - why is the daisy_drv_init() done
by parport_bus_init() rather than just as a regular module init? And
as a result, now when daisy_drv_init() blocks, that blocks
parport_bus_init(). I dunno. It seems to not really have a good reason
for it.
I think it should just be reverted unless Sudip can come up with a
trivial fix. Greg?
Linus