Re: [REGRESSION] failed to boot: commit 1aec4211204d parport: daisy: use new parport device model

[Greg Kroah-Hartman]

On Mon, Mar 25, 2019 at 11:04:49AM -0700, Linus Torvalds wrote:
> On Mon, Mar 25, 2019 at 8:36 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> > I bisected it down to this commit:
> >
> >   aec4211204d ("parport: daisy: use new parport device model")
> 
> I was confused, because no such commit exists.
> 
> But it turns out you have the right commit ID in your subject line,
> and you just dropped the initial '1' .
> 
> Anyway, that commit does look odd - why is the daisy_drv_init() done
> by parport_bus_init() rather than just as a regular module init? And
> as a result, now when daisy_drv_init() blocks, that blocks
> parport_bus_init(). I dunno. It seems to not really have a good reason
> for it.
> 
> I think it should just be reverted unless Sudip can come up with a
> trivial fix. Greg?

I recommend just reverting it for now.  The parport is "odd" in how it
has had to be converted over time to the driver model, which is why I
thought this patch was ok.  Looks like it wasn't, sorry.

greg k-h