RE: [PATCH] scsi: bnx2fc: remove unneeded variable

From: Manish Rangankar
Date: Fri Mar 29 2019 - 00:13:24 EST



> -----Original Message-----
> From: Ding Xiang <dingxiang@xxxxxxxxxxxxxxxxxxxx>
> Sent: Friday, March 29, 2019 8:54 AM
> To: QLogic-Storage-Upstream@xxxxxxxxxx; jejb@xxxxxxxxxxxxx;
> martin.petersen@xxxxxxxxxx
> Cc: linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] scsi: bnx2fc: remove unneeded variable
>
> "rc" is unneeded,just return SUCCESS
>
> Signed-off-by: Ding Xiang <dingxiang@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/scsi/bnx2fc/bnx2fc_io.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c
> b/drivers/scsi/bnx2fc/bnx2fc_io.c index bc9f2a2..8def63c 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_io.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
> @@ -1083,7 +1083,6 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd
> *sc_cmd) static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req) {
> struct bnx2fc_rport *tgt = io_req->tgt;
> - int rc = SUCCESS;
> unsigned int time_left;
>
> io_req->wait_for_comp = 1;
> @@ -1110,7 +1109,7 @@ static int bnx2fc_abts_cleanup(struct
> bnx2fc_cmd *io_req)
> kref_put(&io_req->refcount, bnx2fc_cmd_release);
>
> spin_lock_bh(&tgt->tgt_lock);
> - return rc;
> + return SUCCESS;
> }
>
> /**
> --
> 1.9.1
>

Thanks,
Acked-by: Manish Rangankar <mrangankar@xxxxxxxxxxx>