Re: [PATCH] gcov: include linux/module.h for within_module

[Randy Dunlap]

On 3/29/19 11:01 AM, Randy Dunlap wrote:
> On 3/29/19 10:45 AM, Nick Desaulniers wrote:
>> Fixes commit 8c3d220cb6b5 ("gcov: clang support")
>>
>> Cc: Greg Hackmann <ghackmann@xxxxxxxxxxx>
>> Cc: Tri Vo <trong@xxxxxxxxxxx>
>> Cc: Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>
>> Cc: linux-mm@xxxxxxxxx
>> Cc: kbuild-all@xxxxxx
>> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
>> Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
>> Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> 
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> see https://lore.kernel.org/linux-mm/20190328225107.ULwYw%25akpm@xxxxxxxxxxxxxxxxxxxx/T/#mee26c00158574326e807480fc39dfcbd7bebd5fd
> 
> Did you test this?  kernel/gcov/gcc_4_7.c includes local "gcov.h",
> which includes <linux/module.h>, so why didn't that work or why
> does this patch work?

No, this patch does not fix the build error for me.

> thanks.
> 
>> ---
>>  kernel/gcov/gcc_3_4.c | 1 +
>>  kernel/gcov/gcc_4_7.c | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/kernel/gcov/gcc_3_4.c b/kernel/gcov/gcc_3_4.c
>> index 801ee4b0b969..0eda59ef57df 100644
>> --- a/kernel/gcov/gcc_3_4.c
>> +++ b/kernel/gcov/gcc_3_4.c
>> @@ -16,6 +16,7 @@
>>   */
>>  
>>  #include <linux/errno.h>
>> +#include <linux/module.h>
>>  #include <linux/slab.h>
>>  #include <linux/string.h>
>>  #include <linux/seq_file.h>
>> diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
>> index ec37563674d6..677851284fe2 100644
>> --- a/kernel/gcov/gcc_4_7.c
>> +++ b/kernel/gcov/gcc_4_7.c
>> @@ -13,6 +13,7 @@
>>   */
>>  
>>  #include <linux/errno.h>
>> +#include <linux/module.h>
>>  #include <linux/slab.h>
>>  #include <linux/string.h>
>>  #include <linux/seq_file.h>
>>
> 
> 


-- 
~Randy