Re: [PATCH] gcov: include linux/module.h for within_module

[Nick Desaulniers]

On Fri, Mar 29, 2019 at 11:01 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> On 3/29/19 10:45 AM, Nick Desaulniers wrote:
> > Fixes commit 8c3d220cb6b5 ("gcov: clang support")
> >
> > Cc: Greg Hackmann <ghackmann@xxxxxxxxxxx>
> > Cc: Tri Vo <trong@xxxxxxxxxxx>
> > Cc: Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>
> > Cc: linux-mm@xxxxxxxxx
> > Cc: kbuild-all@xxxxxx
> > Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> > Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
> > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
>
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> see https://lore.kernel.org/linux-mm/20190328225107.ULwYw%25akpm@xxxxxxxxxxxxxxxxxxxx/T/#mee26c00158574326e807480fc39dfcbd7bebd5fd
>
> Did you test this?

Yes, built with gcc 7.3 and
defconfig
+
CONFIG_GCOV_KERNEL=y
CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y
CONFIG_GCOV_FORMAT_4_7=y

> kernel/gcov/gcc_4_7.c includes local "gcov.h",
> which includes <linux/module.h>, so why didn't that work or why
> does this patch work?

Good point. May be something in the configs from 0-day bot.  Boarding
a plane for Bangkok, but can dig further once landed.

Maybe module support was disabled?

--
Thanks,
~Nick Desaulniers