Re: [PATCH 1/3] nvmem: imx-ocotp: use devm_platform_ioremap_resource() to simplify code

[Mukesh Ojha]

On 4/1/2019 10:29 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
Reviewed-by: Mukesh Ojha <mojha@xxxxxxxxxxxxxx>

Cheers,
-Mukesh

> ---
>   drivers/nvmem/imx-ocotp.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c
> index e0b22b6..4cf7b61 100644
> --- a/drivers/nvmem/imx-ocotp.c
> +++ b/drivers/nvmem/imx-ocotp.c
> @@ -467,7 +467,6 @@ MODULE_DEVICE_TABLE(of, imx_ocotp_dt_ids);
>   static int imx_ocotp_probe(struct platform_device *pdev)
>   {
>   	struct device *dev = &pdev->dev;
> -	struct resource *res;
>   	struct ocotp_priv *priv;
>   	struct nvmem_device *nvmem;
>   
> @@ -477,8 +476,7 @@ static int imx_ocotp_probe(struct platform_device *pdev)
>   
>   	priv->dev = dev;
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	priv->base = devm_ioremap_resource(dev, res);
> +	priv->base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(priv->base))
>   		return PTR_ERR(priv->base);
>