Re: [PATCH 2/3] nvmem: mxs-ocotp: use devm_platform_ioremap_resource() to simplify code

[Mukesh Ojha]

On 4/1/2019 10:29 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
Reviewed-by: Mukesh Ojha <mojha@xxxxxxxxxxxxxx>

Cheers,
-Mukesh

> ---
>   drivers/nvmem/mxs-ocotp.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/nvmem/mxs-ocotp.c b/drivers/nvmem/mxs-ocotp.c
> index 53122f5..fbb7db6 100644
> --- a/drivers/nvmem/mxs-ocotp.c
> +++ b/drivers/nvmem/mxs-ocotp.c
> @@ -145,7 +145,6 @@ static int mxs_ocotp_probe(struct platform_device *pdev)
>   	struct device *dev = &pdev->dev;
>   	const struct mxs_data *data;
>   	struct mxs_ocotp *otp;
> -	struct resource *res;
>   	const struct of_device_id *match;
>   	int ret;
>   
> @@ -157,8 +156,7 @@ static int mxs_ocotp_probe(struct platform_device *pdev)
>   	if (!otp)
>   		return -ENOMEM;
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	otp->base = devm_ioremap_resource(dev, res);
> +	otp->base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(otp->base))
>   		return PTR_ERR(otp->base);
>